opentelemetry-collector: bump chart to v0.131.1 and lock ebpfProfiler default image tag#449
opentelemetry-collector: bump chart to v0.131.1 and lock ebpfProfiler default image tag#449povilasv wants to merge 3 commits into
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a56cf161b9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| maintainers: | ||
| - name: povilasv | ||
| appVersion: 0.147.0 | ||
| appVersion: 0.151.0 |
There was a problem hiding this comment.
Regenerate rendered examples after appVersion bump
Bumping appVersion to 0.151.0 without updating charts/opentelemetry-collector/examples/**/rendered leaves the checked-in manifests on the old 0.147.0 image, so CI paths that apply rendered examples are no longer validating the version shipped by this chart change. I verified this by checking .github/workflows/collector-test.yaml and .github/workflows/ebpf-test.yaml, which run kubectl apply -f ./charts/opentelemetry-collector/examples/daemonset-and-deployment/rendered, while that rendered manifest still references opentelemetry-collector-contrib:0.147.0.
Useful? React with 👍 / 👎.
Motivation
ebpfProfilerpreset uses a specific, known-safe image tag by default while still allowing user overrides viaimage.tag.Description
Chart.yamltoversion: 0.131.1andappVersion: 0.151.0.v0.131.1andv0.131.0entries toCHANGELOG.mdnoting theebpfProfilerimage tag behavior and the app bump.templates/_custom_helpers.tplin theopentelemetry-collector.imagehelper to set the default$imageTagto"0.147.0"when.Values.presets.ebpfProfiler.enabled, while keeping the existing repository selection logic and allowingimage.tagandimage.digestto override.Testing
helm lintagainst the chart and it succeeded.helm templatefor an installation with.Values.presets.ebpfProfiler.enabled = trueand verified the image tag defaults to0.147.0.image.tagoverride and verified the override was applied successfully.Codex Task