Support eBPF profile forwarding via OTLP exporter#452
Conversation
Forward eBPF profiler profiles to the node-local agent by default while keeping Kubernetes profile enrichment on the standard agent collector. Set the Coralogix profile ingress header on profile exports and regenerate opentelemetry-collector examples.
povilasv
force-pushed
the
codex/bump-collector-chart-v0.151.0
branch
from
0c78923 to
b32d3a1
Compare
povilasv
changed the title
|
So fast. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d04a67dda0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| fieldPath: metadata.name | ||
| {{- end }} | ||
| {{- if or .Values.presets.kubeletMetrics.enabled .Values.presets.kubernetesExtraMetrics.perNode }} | ||
| {{- if or .Values.presets.kubeletMetrics.enabled .Values.presets.kubernetesExtraMetrics.perNode (and .Values.presets.otlpExporter.enabled (contains "K8S_NODE_IP" .Values.presets.otlpExporter.endpoint)) }} |
There was a problem hiding this comment.
This change injects K8S_NODE_IP for otlpExporter endpoints only in _pod.tpl, so forwarding with endpoint: ${env:K8S_NODE_IP}:4317 still breaks when collectorCRD.generate=true because templates/opentelemetrycollector.yaml only sets K8S_NODE_IP behind presets.kubeletMetrics.enabled (lines 104-110 in that template). In that CRD path, enabling otlpExporter without kubelet metrics leaves the env var unset, which makes the exporter endpoint invalid at runtime. Please apply the same otlpExporter/K8S_NODE_IP condition to the CRD env block as well.
Useful? React with 👍 / 👎.
3 participants
Summary
otlpExporterpresetprofilesCollectionK8S_NODE_IPwhen the exporter endpoint references itx-coralogix-ingress: otlp/v1.10.0on Coralogix profile exportscontainer.idbefore falling back to connection metadataTesting
helm lint charts/opentelemetry-collectormake validate-examples CHARTS=opentelemetry-collectormake check-examples CHARTS=opentelemetry-collector MAX_PARALLEL_EXAMPLES=1git diff --check