fix(opentelemetry-collector): 2 updates for spanMetricsMulti#466
Merged
Conversation
…s connectors Routed spanmetrics connectors now inherit the same errorTracking dimensions as spanmetrics/default, with deduplication when those keys are already listed in extraDimensions. Co-authored-by: Cursor <cursoragent@cursor.com>
cazorla19
requested review from
a team,
nicolastakashi and
oded-dd
as code owners
iblancasa
reviewed
May 26, 2026
… backward compatible Restore prior routed connector dimension behavior by default and add inheritDefaultDimensions opt-in to align routed connectors with spanmetrics/default while still deduplicating status code dimensions. Co-authored-by: Cursor <cursoragent@cursor.com>
…ompatibility defaults Keep spanMetricsMulti backward compatible by default while allowing users to opt in to single spanMetrics connector defaults (`add_resource_attributes` and `histogram.unit: ms`) for default and routed connectors. Co-authored-by: Cursor <cursoragent@cursor.com>
cazorla19
changed the title
cazorla19
changed the title
Co-authored-by: Cursor <cursoragent@cursor.com>
povilasv
reviewed
May 29, 2026
…es breaking by default Apply unified dimensions and single spanMetrics connector defaults (add_resource_attributes and histogram.unit=ms) to default and routed spanMetricsMulti connectors by default, since APM requires ms-based span metrics. Co-authored-by: Cursor <cursoragent@cursor.com>
povilasv
reviewed
May 29, 2026
povilasv
left a comment
povilasv
left a comment
There was a problem hiding this comment.
can you create some example with spanMetricsMulti?
Or there is one? I cannot find it :D
Author
|
@povilasv it's there :D |
povilasv
approved these changes
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
unify spanMetricsMulti dimensions across connectors. Fixes CDS-2997. Routed spanmetrics connectors now inherit the same errorTracking dimensions as
spanmetrics/default, with deduplication when those keys are already listed in extraDimensions.add opt-in spanMetricsMulti connector compatibility defaults. Fixes CDS-3000. Add opt-in
presets.spanMetricsMulti.inheritConnectorCompatibilityDefaultssospanmetrics/defaultand routedspanmetrics/<index>connectors can match singlespanMetricscompatibility defaults by settingadd_resource_attributes: trueandhistogram.unit: ms, while keeping existingspanMetricsMultibehavior unchanged by default.