Add E2E for supervisor in Otel-integration #778
Conversation
Signed-off-by: Israel Blancas <[email protected]>
iblancasa
requested review from
a team,
ShauliSolomovich,
avivgold098,
nicolastakashi and
oded-dd
as code owners
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: aac1b1153c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Signed-off-by: Israel Blancas <[email protected]>
Signed-off-by: Israel Blancas <[email protected]>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6a718d05c7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| host := testhelpers.HostEndpoint(t) | ||
| firstPort := testhelpers.GetFreePort(t) | ||
| secondPort := testhelpers.GetFreePort(t) | ||
| testServer := opampserver.StartTestServer(t, fmt.Sprintf("0.0.0.0:%d", firstPort)) |
There was a problem hiding this comment.
Both ports are chosen via GetFreePort before either server is started. Because GetFreePort closes the listener immediately, the OS can hand back the same port twice, making the second StartTestServer intermittently fail with “address already in use.” This will be flaky on shared CI runners; consider starting the first server before selecting the second port or returning an already‑bound listener.
Useful? React with 👍 / 👎.
Signed-off-by: Israel Blancas <[email protected]>
1 participant
CX-22185