fix(eks-fargate): accept secret keys PRIVATE_KEY and CORALOGIX_PRIVATE_KEY#942
Draft
vjofusha wants to merge 4 commits into
Draft
fix(eks-fargate): accept secret keys PRIVATE_KEY and CORALOGIX_PRIVATE_KEY#942vjofusha wants to merge 4 commits into
vjofusha wants to merge 4 commits into
Conversation
Aligns the Kubernetes secret key name with the container env var name (CORALOGIX_PRIVATE_KEY), removing the confusing mismatch where the env var and secret key used different names. BREAKING CHANGE: existing deployments must recreate the coralogix-keys secret with the new key name before applying updated manifests. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…PRIVATE_KEY" This reverts commit 30a840a.
Makes the shell variable match the container env var name, eliminating the confusing mismatch where the export and the resulting container env var used different names. The Kubernetes secret key remains PRIVATE_KEY (repo-wide convention). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…secret keys Adds optional fallback so the coralogix-keys secret works with either key name. PRIVATE_KEY remains the documented standard (per repo convention); CORALOGIX_PRIVATE_KEY is accepted silently for users who have already created their secret with that key name. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
vjofusha
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aligns the Kubernetes secret key name with the container env var name (CORALOGIX_PRIVATE_KEY), removing the confusing mismatch where the env var and secret key used different names.
This avoid the need for this ambiguous documentation change - https://github.com/coralogix/documentation/pull/2435
BREAKING CHANGE: existing deployments must recreate the coralogix-keys secret with the new key name before applying updated manifests.
Description
Fixes #How Has This Been Tested?
Checklist: