Skip to content

Add stat metrics support #948

Open
pinoOgni wants to merge 3 commits into
masterfrom
pgn/stat-metrics
Open

Add stat metrics support #948
pinoOgni wants to merge 3 commits into
masterfrom
pgn/stat-metrics

Conversation

@pinoOgni

@pinoOgni pinoOgni commented Jun 24, 2026

Copy link
Copy Markdown

Description

This PR adds stat metrics option to OBI config, defaults false.

Fixes #

How Has This Been Tested?

Checklist:

  • I have updated the relevant Helm chart(s) version(s)
  • I have updated the relevant component changelog(s)
  • This change does not affect any particular component (e.g. it's CI or docs change)

Signed-off-by: Giuseppe Ognibene <giuseppe.ognibene@coralogix.com>
@CLAassistant

CLAassistant commented Jun 24, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

Signed-off-by: Giuseppe Ognibene <giuseppe.ognibene@coralogix.com>

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7283f5ed83

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

name: otel-integration
description: OpenTelemetry Integration
version: 0.0.319
version: 0.0.320

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Sync global.version with the chart bump

When this chart version is bumped to 0.0.320, otel-integration/k8s-helm/values.yaml still has global.version: "0.0.319". The PR check in .github/workflows/otel-integration-version-check.yml reads both values and exits if they differ, so this change will fail for this k8s-helm PR; if bypassed, default rendered collectors will keep advertising helm-otel-integration/0.0.319 in distribution headers.

Useful? React with 👍 / 👎.

Signed-off-by: Giuseppe Ognibene <giuseppe.ognibene@coralogix.com>

@douglascamata douglascamata left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the comment from Codex.

@iblancasa

Copy link
Copy Markdown
Contributor

Please check the comment from Codex.

I'm surprised CI didn't fail

@iblancasa iblancasa self-requested a review June 25, 2026 11:25
@pinoOgni

Copy link
Copy Markdown
Author

Please check the comment from Codex.

Hi @douglascamata, I saw the comment but afaiu it is stale. The global.version is already 0.0.320.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants