CORE-19621: Rename createdTimestamp to rotationInitiatedTimestamp #5725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jenkins build for PR 5725 build 3 Build Successful: |
malachyb
requested review from
driessamyn,
jasonbyrner3,
ronanbrowne,
rick-r3,
simon-johnson-r3,
blsemo,
Omar-awad,
aditisdesai,
vinir3,
vkolomeyko,
thiagoviana,
Sakpal,
dickon and
owenstanford
as code owners
simon-johnson-r3
requested changes
Feb 20, 2024
| @@ -8,15 +8,15 @@ import java.time.Instant | |||
| * @param tenantId Either a holding identity ID, the value 'master' for master wrapping key or one of the values | |||
| * 'p2p', 'rest', 'crypto' for corresponding cluster-level tenant. | |||
| * @param status Overall status of the key rotation. Either In Progress or Done. | |||
| * @param createdTimestamp Timestamp of then the key rotation request was received. | |||
| * @param rotationInitiatedTimestamp Timestamp of then the key rotation request was received. | |||
There was a problem hiding this comment.
this text (which you didn't write) doesn't make sense, we should take the opportunity to fix it
There was a problem hiding this comment.
I'm guessing it should say "when" instead of "then"? I think that would fix the sentence and make it make more sense.
|
simon-johnson-r3
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The name of the field
createdTimestampcan cause confusion about what it refers to, so this PR renames it torotationInitiatedTimestamp