CORE-19745: Set state manager action only for the last messages #5734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -706,7 +709,12 @@ internal class StatefulSessionManagerImpl( | |||
| } | |||
| } | |||
| } | |||
| contexts.map { TraceableResult(it.trace, result) } | |||
| otherContexts.map { | |||
There was a problem hiding this comment.
If we discard the null results in processSessionMessages() why do we bother with the otherContexts?
There was a problem hiding this comment.
We want to have a reply to every message.
|
Jenkins build for PR 5734 build 3 Build Successful: |
|
owenstanford
approved these changes
Feb 20, 2024
yift-r3
requested review from
driessamyn,
jasonbyrner3,
ronanbrowne,
rick-r3,
simon-johnson-r3,
blsemo,
Omar-awad,
aditisdesai,
vinir3,
vkolomeyko,
thiagoviana,
Sakpal and
dickon
as code owners
driessamyn
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.