Branch for merge to master#25
Open
rogersanick wants to merge 84 commits into
Open
Conversation
…he body of the method was empty.
Added comment about quasar instrumentation error when running flow tests and how to resolve it
* Fixes typos. * Further typos. * Simplifies and clarifies check for amount > 0. * Adds imports required by solutions. * Expands test to ensure amount and paid fields have matching tokens. * Comments out test. * Adds a withNewLender() test. * Fixes indentation on flow tests. * Adds run configs for the flow tests.
Merge Corda training application template written in Java
Fixing typos, improving documentation for IOUIssueFlowTests regarding quasar
…and write java testing suite
…d out test cases in java
Halfway through creating tests for IOUSettle contract tests
Encountered bug in test#9
…(state + contract + flow tests)
…tions into branchForMerge
amoothart
suggested changes
Dec 18, 2018
amoothart
left a comment
amoothart
left a comment
Contributor
There was a problem hiding this comment.
couple small tweaks, looks really good.
Make sure that the test hints match the java syntax
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <project version="1"> | ||
| <project version="4"> | ||
| <component name="CompilerConfiguration"> |
Contributor
There was a problem hiding this comment.
As in the template be careful about checking in .idea files and use the .gitignore
amoothart
reviewed
Dec 19, 2018
| @@ -1,6 +0,0 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
Contributor
There was a problem hiding this comment.
Did you confirm that you can check out the project from scratch and load in intelliJ just fine? we have to protect the process for loading the training app onto a new computer as it is very expensive in many classes.
Contributor
|
Can you fix the PR name to something more meaningful? The commits here show everything from the whole history, this should be limited to the changes you made. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.