fix(include): initialize missing configs safely - #74
Open
randomcat4 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this fixes
initialis intended to create an Include config when the target file does not exist. The current startup path schedules that write through the normal debounced writer and immediately reads the file again, so first startup can still fail withENOENT.The same catch block also treats parsing and permission failures as a missing file. If an existing JSON or YAML file is malformed, startup rejects but the scheduled write can still replace the original file with
initial.Root cause
Service.initcatches every error from the first read, calls the deferredwriteFile()helper, and then reads again without waiting for the write. This both races missing-file initialization and turns unrelated read failures into destructive recovery attempts.Changes
initialwhen the first read fails withENOENT.Tests
Local verification: