fix(core): support symbol and prototype-named events - #82
Open
rekcilyssup wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #50
Problem
ctx.on()accepts symbols, butemit()/parallel()/serial()/bail()threw
TypeError: name.startsWith is not a functionon dispatch —_resolve()narrowed every event name to
stringand calledstartsWith()unconditionally.Object.prototypeproperties (e.g.__proto__)failed during registration, because
_hookswas a plain object whose inheritedprototype shadowed own keys.
Fix
In
packages/core/src/events.ts:_hooksis now a null-prototype table, so prototype-named keys are plain ownproperties.
_resolve()only applies theinternal/prefix check to string names; symbolspass through to the hook table unchanged.
register()/unregister()now track the event key, andunregister()deletesthe bucket when the last listener is disposed.
Tests
Added 5 tests: symbol dispatch via
emitandparallel,__proto__registrationand dispatch, and bucket release after disposing the last listener.
Verified locally:
yarn lint,yarn build,yarn test(167 passed).