fix(core): guard waterfall next against double invocation - #83
Open
rekcilyssup wants to merge 1 commit into
Open
fix(core): guard waterfall next against double invocation#83rekcilyssup wants to merge 1 commit into
rekcilyssup wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #42
Problem
ctx.waterfall()passed a single sharednextcontinuation to everymiddleware frame. Calling it twice in one frame advanced the shared queue
again and re-invoked the terminal callback, duplicating terminal side
effects.
Fix
In
packages/core/src/events.ts, each middleware frame now receives its ownguarded continuation:
nexttwicethrows
next() should only be called once;every listener and the terminal, preserving the existing contract used by
internal/update,internal/get, andinternal/set;once and the terminal runs exactly once.
Tests
Added 3 tests: double
next()in one frame throws while the terminal runsonce, reusing a previous frame's
nextthrows, and an async listener callingnext()afterawaitstill completes the chain in order.Verified locally:
yarn lint,yarn build,yarn test(170 passed).