fix(core): do not re-enter lifecycle from a failed outcome - #98
Open
justkyriecai wants to merge 1 commit into
Open
fix(core): do not re-enter lifecycle from a failed outcome#98justkyriecai wants to merge 1 commit into
justkyriecai wants to merge 1 commit into
Conversation
Author
|
for the reason that cordis is vendored into dsh, and fiber state feeds the core agent loop, when a FAILED fiber silently rerun its plugin body means duplicate registrations and side effects while the agent keeps seeing FAILED. Like a wrong state and phantom execution. Request to merge. Love to contribute. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #95
After a plugin fails, a dependency refresh can make the target satisfiable again and start
_reload()while_erroris still set, so the body runs again but the fiber keeps reporting FAILED. Skip epoch-driven lifecycle transitions while failed;update()clears_errorand restarts.