Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .changeset/dirty-clocks-play.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
---
'arui-scripts': minor
---

Исправлен порядок инструкций в Dockerfile-шаблоне команды `docker-build`: шаг удаления npm
(`deleteNpm: true`) выполнялся после переключения на непривилегированного пользователя
(`runFromNonRootUser: true`) и падал с ошибкой прав доступа. Теперь npm удаляется до инструкции `USER nginx` — так же, как это уже было
сделано в шаблоне для `docker-build-compiled`
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
describe('dockerfile.template (normal mode)', () => {
function getTemplate(deleteNpm: boolean) {
function getTemplate(deleteNpm: boolean, runFromNonRootUser = false) {
jest.resetModules();
jest.doMock('../../configs/app-configs', () => ({
configs: {
baseDockerImage: 'test-image',
clientOnly: false,
nginx: null,
runFromNonRootUser: false,
runFromNonRootUser,
buildPath: '.build',
overridesPath: [],
deleteNpm,
Expand All @@ -30,6 +30,16 @@ describe('dockerfile.template (normal mode)', () => {

expect(template).not.toContain('rm -rf /usr/local/bin/npm');
});

it('should place the removal step before USER nginx when runFromNonRootUser is enabled', () => {
const template = getTemplate(true, true);
const rmStep = template.indexOf('rm -rf /usr/local/bin/npm');
const userNginx = template.indexOf('USER nginx');

expect(rmStep).toBeGreaterThan(-1);
expect(userNginx).toBeGreaterThan(-1);
expect(rmStep).toBeLessThan(userNginx);
});
});

describe('dockerfile-compiled.template (compiled mode)', () => {
Expand Down
11 changes: 6 additions & 5 deletions packages/arui-scripts/src/templates/dockerfile.template.ts
Original file line number Diff line number Diff line change
Expand Up @@ -32,18 +32,19 @@ ADD $START_SH_LOCATION /src/start.sh
ADD $NGINX_CONF_LOCATION ${nginxConfTargetLocation}
${nginx ? 'ADD $NGINX_BASE_CONF_LOCATION /etc/nginx/nginx.conf' : ''}

${
configs.deleteNpm
? 'RUN rm -rf /usr/local/bin/npm /usr/local/bin/npx /usr/local/lib/node_modules/npm'
: ''
}

${nginxNonRootPart}

${
configs.runFromNonRootUser
? `ADD --chown=nginx:nginx ${appPathToAdd} ${appTargetPath}`
: `ADD ${appPathToAdd} ${appTargetPath}`
}
${
configs.deleteNpm
? 'RUN rm -rf /usr/local/bin/npm /usr/local/bin/npx /usr/local/lib/node_modules/npm'
: ''
}
${configs.clientOnly ? 'COPY env-config.jso[n] /src/' : ''}
${configs.clientOnly ? 'CMD ["nginx"]' : ''}
`;
Expand Down
2 changes: 1 addition & 1 deletion packages/create-arui-scripts-app/src/versions.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/** Версия arui-scripts, которую scaffold кладёт в package.json нового проекта.
* Генерируется скриптом scripts/sync-arui-scripts-version.js при сборке.
*/
export const DEFAULT_ARUI_SCRIPTS_VERSION = '23.5.1';
export const DEFAULT_ARUI_SCRIPTS_VERSION = '23.6.0';
Loading