-
Notifications
You must be signed in to change notification settings - Fork 132
fw/services/battery: add optional 80% charge limit to extend battery lifespan #1156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
spr4bhu
wants to merge
2
commits into
coredevices:main
Choose a base branch
from
spr4bhu:battery-charge-limit
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+120
−1
Open
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| /* SPDX-FileCopyrightText: 2025 Core Devices LLC */ | ||
| /* SPDX-License-Identifier: Apache-2.0 */ | ||
|
|
||
| #pragma once | ||
|
|
||
| #include "pbl/services/battery/battery_state.h" | ||
|
|
||
| // The battery charge limit service optionally stops charging at 80% and resumes at 77% | ||
| // to reduce battery degradation from sustained high charge levels. | ||
|
|
||
| void battery_charge_limit_init(void); | ||
|
|
||
| void battery_charge_limit_evaluate(PreciseBatteryChargeState state); | ||
|
|
||
| bool battery_charge_limit_is_active(void); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,77 @@ | ||
| /* SPDX-FileCopyrightText: 2025 Core Devices LLC */ | ||
| /* SPDX-License-Identifier: Apache-2.0 */ | ||
|
|
||
| #include "pbl/services/battery/battery_charge_limit.h" | ||
|
|
||
| #include "drivers/battery.h" | ||
| #include "drivers/rtc.h" | ||
| #include "pbl/services/regular_timer.h" | ||
| #include "shell/prefs.h" | ||
| #include "system/logging.h" | ||
|
|
||
| #define CHARGE_LIMIT_PCT 80 | ||
| #define CHARGE_RESUME_PCT 77 | ||
| #define MIN_TOGGLE_INTERVAL_S 60 | ||
| #define PERIODIC_CHECK_INTERVAL_S 60 | ||
|
|
||
| //////////////////////// | ||
| // State | ||
| T_STATIC bool s_limit_active; | ||
| T_STATIC RtcTicks s_last_toggle_ticks; | ||
| static RegularTimerInfo s_periodic_timer; | ||
|
|
||
| static void prv_periodic_timer_cb(void *data) { | ||
| BatteryChargeState charge = battery_get_charge_state(); | ||
| PreciseBatteryChargeState state = { | ||
| .pct = charge.charge_percent, | ||
| .is_plugged = charge.is_plugged, | ||
| .is_charging = charge.is_charging, | ||
| }; | ||
| battery_charge_limit_evaluate(state); | ||
| } | ||
|
|
||
| void battery_charge_limit_init(void) { | ||
| s_periodic_timer.cb = prv_periodic_timer_cb; | ||
| regular_timer_add_multisecond_callback(&s_periodic_timer, PERIODIC_CHECK_INTERVAL_S); | ||
| } | ||
|
|
||
| void battery_charge_limit_evaluate(PreciseBatteryChargeState state) { | ||
| if (!shell_prefs_get_charge_limit_enabled()) { | ||
| if (s_limit_active) { | ||
| battery_set_charge_enable(true); | ||
| s_limit_active = false; | ||
| PBL_LOG_INFO("Charge limit: disabled, re-enabling charging"); | ||
| } | ||
| return; | ||
| } | ||
|
|
||
| if (!state.is_plugged) { | ||
| s_limit_active = false; | ||
| return; | ||
| } | ||
|
|
||
| // Rate limit: don't toggle more than once per MIN_TOGGLE_INTERVAL_S | ||
| if (s_last_toggle_ticks != 0) { | ||
| RtcTicks now = rtc_get_ticks(); | ||
| RtcTicks elapsed = (now - s_last_toggle_ticks) / RTC_TICKS_HZ; | ||
| if (elapsed < MIN_TOGGLE_INTERVAL_S) { | ||
| return; | ||
| } | ||
| } | ||
|
|
||
| if (state.pct >= CHARGE_LIMIT_PCT && !s_limit_active) { | ||
| battery_set_charge_enable(false); | ||
| s_limit_active = true; | ||
| s_last_toggle_ticks = rtc_get_ticks(); | ||
| PBL_LOG_INFO("Charge limit: disabling charging at %d pct", state.pct); | ||
| } else if (state.pct <= CHARGE_RESUME_PCT && s_limit_active) { | ||
| battery_set_charge_enable(true); | ||
| s_limit_active = false; | ||
| s_last_toggle_ticks = rtc_get_ticks(); | ||
| PBL_LOG_INFO("Charge limit: resuming charging at %d pct", state.pct); | ||
| } | ||
| } | ||
|
|
||
| bool battery_charge_limit_is_active(void) { | ||
| return s_limit_active; | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While plugged in, if not charging, the watch will run from USB power, so the battery will not drain. I guess you can simply disable the charger and forget about any hysteresis.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made the changes, thanks.