Skip to content

vlcd 3V3 low pulse when lcd initialize#406

Closed
Jiyun-Yang wants to merge 1 commit into
coredevices:mainfrom
Jiyun-Yang:main
Closed

vlcd 3V3 low pulse when lcd initialize#406
Jiyun-Yang wants to merge 1 commit into
coredevices:mainfrom
Jiyun-Yang:main

Conversation

@Jiyun-Yang
Copy link
Copy Markdown
Contributor

create a low level for VLCD_3V3 when initial the lcd as some JDI pin with a default PU status

Comment thread src/fw/drivers/sf32lb52/display_jdi.c Outdated

static void prv_bsp_pin_set(int pin, int val, int is_porta)
{
GPIO_TypeDef *gpio = (is_porta) ? hwp_gpio1 : hwp_gpio2;
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we always use hwp_gpio1

Comment thread src/fw/drivers/sf32lb52/display_jdi.c Outdated
Comment on lines +151 to +153
HAL_GPIO_Init(gpio, &GPIO_InitStruct);

HAL_GPIO_WritePin(gpio, pin, (GPIO_PinState)val);
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not use gpio.h interface?

… the lcd as some JDI pin with a default PU status

Signed-off-by: Yang Jiyun <yangjiyun@pro-well.tech>
@gmarull
Copy link
Copy Markdown
Member

gmarull commented Oct 31, 2025

merged tweaking a few things

@gmarull gmarull closed this Oct 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants