services/voice_endpoint: Fix voice crash from invalid session setup result code#464
Merged
Merged
Conversation
Signed-off-by: Joshua Jun <joshuajun@proton.me>
gmarull
approved these changes
Nov 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A user experienced a watch crash when attempting voice replies to text messages.
The coredump revealed that the watch was sent a session setup result message with an invalid
VoiceEndpointResultvalue of 0x11 (17). The VoiceEndpointResult enum only defines values 0x00-0x06, but the protocol handler in voice_endpoint.c was passing the raw message value to voice_handle_session_setup_result() without validation.This invalid enum value caused undefined behavior that allowed code execution to reach an unexpected state, eventually triggering an assertion failure.