Skip to content

Revert "fw/apps: Include health in launcher if not quick launched" #472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jplexer merged 1 commit into from
Nov 14, 2025
Merged

Revert "fw/apps: Include health in launcher if not quick launched" #472

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/fw/apps/system_apps/health/health.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,6 +169,9 @@ const PebbleProcessMd *health_app_get_info(void) {
.common = {
.main_func = &prv_main,
.uuid = UUID_HEALTH_DATA_SOURCE,
#if CAPABILITY_HAS_CORE_NAVIGATION4
.visibility = ProcessVisibilityHidden,
#endif
},
.icon_resource_id = RESOURCE_ID_MENU_ICON_HEALTH,
.name = i18n_noop("Health"),
Expand Down
9 changes: 0 additions & 9 deletions src/fw/apps/system_apps/launcher/default/launcher_app.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,11 +23,9 @@
#include "applib/ui/app_window_stack.h"
#include "kernel/pbl_malloc.h"
#include "shell/normal/app_idle_timeout.h"
#include "shell/normal/quick_launch.h"
#include "system/passert.h"
#include "shell/prefs.h"
#include "process_state/app_state/app_state.h"
#include "services/normal/timeline/timeline.h"
#include "util/attributes.h"

typedef struct LauncherAppWindowData {
Expand Down Expand Up @@ -66,13 +64,6 @@ static void prv_will_focus(bool in_focus) {
// AppMenuDataSource callbacks

static bool prv_app_filter_callback(PBL_UNUSED AppMenuDataSource *source, AppInstallEntry *entry) {
// Skip Health app if it's set as the quick launch single-click up action
const Uuid health_uuid = UUID_HEALTH_DATA_SOURCE;
const AppInstallId health_install_id = app_install_get_id_for_uuid(&health_uuid);
const AppInstallId quick_launch_app_id = quick_launch_single_click_get_app(BUTTON_ID_UP);
if (entry->install_id == health_install_id && health_install_id == quick_launch_app_id) {
return false;
}
// Skip watchfaces and hidden apps
return (!app_install_entry_is_watchface(entry) && !app_install_entry_is_hidden((entry)));
}
Expand Down
Loading