Skip Google Play in-app update check for non-Google Play installs#206
Draft
aveao wants to merge 2 commits into
Draft
Skip Google Play in-app update check for non-Google Play installs#206aveao wants to merge 2 commits into
aveao wants to merge 2 commits into
Conversation
sjp4
reviewed
May 22, 2026
Member
sjp4
left a comment
sjp4
left a comment
There was a problem hiding this comment.
Do you think there's any risk this doesn't work? The code looks sensible, but unfortunately it's an epic pain to test this flow (creating a dedicated build, sending that to the play store on a special internal channel, installing it, publishing an update, etc, etc) so I'm kinda scared to touch it.
Contributor
Author
|
What if we first merge a debug line that just logs what it's installed through, then a release or two later we merge this? |
Member
|
That should work |
Resolve the installer package (getInstallSourceInfo on API 30+, the deprecated getInstallerPackageName below it; null on failure) and log it as debug at the start of the update check flow, instead of blocking the Play update check for non-Play installs. Adds the PLAY_STORE_PACKAGE constant in prep for gating the Play flow on it later, and uses it in getPlayStoreMarketIntent in place of the hardcoded string.
Resolve the installer at init and only build the Play requestUpdateFlow() pipeline when it is com.android.vending. Sideloaded/adb/other-store/debug installs short-circuit to NoUpdateAvailable, avoiding the Play update API call and its notification on builds that can't be updated through Play. The installer is logged as debug in both branches.
aveao
force-pushed
the
no-play-update-check
branch
from
8782c00 to
8d5c086
Compare
Contributor
Author
|
Opened #210 for that. This PR now builds on that, so it's marked as draft until that's merged, feel free to undraft later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nicety for #184. It's harmless but no point in checking and no point in resulting scary logs if it isn't installed through gplay.