Skip to content

android: stricten mimetypes app accepts from */* to application/octet-stream#209

Open
aveao wants to merge 1 commit into
coredevices:masterfrom
aveao:mimetype-strictening
Open

android: stricten mimetypes app accepts from */* to application/octet-stream#209
aveao wants to merge 1 commit into
coredevices:masterfrom
aveao:mimetype-strictening

Conversation

@aveao
Copy link
Copy Markdown
Contributor

@aveao aveao commented May 22, 2026

Apparently some users have an issue with the app being incorrectly used for opening certain types, like PDFs.

https://discord.com/channels/221364737269694464/221364737269694464/1507412822324412446

This strictens the accepted content types. We could drop this line fully and rely on the filter lines above for pbw, pbz, pbl, but it might break opens from situations where real filename aren't reported.

@aveao aveao marked this pull request as ready for review May 22, 2026 16:12
@sjp4
Copy link
Copy Markdown
Member

sjp4 commented May 22, 2026

When I tested this out it didn't work (pebble did not appear when i clicked on a pbw/pbz from the file manager app).

I'm not aware of any way around this other than making the choice that we don't support loading those files types from provider-based sources (we have made the decision to make it work from all sources, at the cost of being annoying to the user)

@aveao
Copy link
Copy Markdown
Contributor Author

aveao commented May 22, 2026

It works for me with pbws at least, with the (google pixel) files app, I'll test pbz shortly.

@aveao
Copy link
Copy Markdown
Contributor Author

aveao commented May 22, 2026

Both still work for me (but successfully, it was offered for PDFs before but not anymore). Have you tested with no */* at all, or also with application/octet-stream?

Screenshot_20260522-185129 Screenshot_20260522-185138

@sjp4
Copy link
Copy Markdown
Member

sjp4 commented May 22, 2026

I'm not in front of it right now but was likely testing with the samsung files app on my primary dev phone - I'll try to test that again

@aveao
Copy link
Copy Markdown
Contributor Author

aveao commented May 22, 2026

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants