android: stricten mimetypes app accepts from */* to application/octet-stream#209
Open
aveao wants to merge 1 commit into
Open
android: stricten mimetypes app accepts from */* to application/octet-stream#209aveao wants to merge 1 commit into
aveao wants to merge 1 commit into
Conversation
Member
|
When I tested this out it didn't work (pebble did not appear when i clicked on a pbw/pbz from the file manager app). I'm not aware of any way around this other than making the choice that we don't support loading those files types from provider-based sources (we have made the decision to make it work from all sources, at the cost of being annoying to the user) |
Contributor
Author
|
It works for me with pbws at least, with the (google pixel) files app, I'll test pbz shortly. |
Contributor
Author
Member
|
I'm not in front of it right now but was likely testing with the samsung files app on my primary dev phone - I'll try to test that again |
Contributor
Author
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Apparently some users have an issue with the app being incorrectly used for opening certain types, like PDFs.
https://discord.com/channels/221364737269694464/221364737269694464/1507412822324412446
This strictens the accepted content types. We could drop this line fully and rely on the filter lines above for pbw, pbz, pbl, but it might break opens from situations where real filename aren't reported.