Add fake watch setting and improve FakeLibPebble#226
Open
jmsunseri wants to merge 7 commits into
Open
Conversation
Allow selecting a fake watch type from debug settings to use FakeLibPebble instead of a real Bluetooth connection. Simplify FakeLibPebble by removing random data generation and adding displayName to WatchHardwarePlatform.
Author
|
cc @ericmigi |
Member
|
Why do you want this? |
Author
I was working on a feature that required access to the settings of a watch but I was having a lot of difficulty connecting a watch to a google phone emulator and this seemed like a very simple work around so that you could access and test features that required a connected watch without the watch really being there. |
Author
|
@sjp4 is there anything blocking this from going forward? i've got several things i'd like to work on and improve and this would make it so much easier to work on these things? |
Use `binds` to register additional types directly on the LibPebble singleton instead of defining separate singleites with manual casts. For LibPebble3 resolution, replace the unsafe cast with a safe `as?` cast and provide a clearer error message when fake watches are in use.
Move add, remove, and set active fake watch operations out of WatchSettingsScreen and into CoreConfigHolder extension functions. Also add a transform-based update method to CoreConfigHolder.
Simplifies the consumer hardware filter in WatchSettingsScreen and fixes FakeLibPebble to filter by ID and watchface type.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow selecting a fake watch type from debug settings to use FakeLibPebble instead of a real Bluetooth connection. Simplify FakeLibPebble by removing random data generation and adding displayName to WatchHardwarePlatform.