libpebble3: Compose-free public API (PebbleBitmap), extract Contacts, relocate fakes#231
Open
SalvatoreT wants to merge 1 commit into
Open
libpebble3: Compose-free public API (PebbleBitmap), extract Contacts, relocate fakes#231SalvatoreT wants to merge 1 commit into
SalvatoreT wants to merge 1 commit into
Conversation
… relocate fakes Decouple the published API surface from Compose so external consumers don't need AndroidX/Compose, and tidy the surface for standalone consumption: - Introduce image/PebbleBitmap.kt: a pure-Kotlin ARGB8888 bitmap. Replace ImageBitmap with PebbleBitmap in every published bitmap-returning API (Screenshot.takeScreenshot, NotificationApps.getAppIcon, Contacts.getContactImage) and all of their implementations. Add util conversion helpers (PebbleBitmap.toImageBitmap / Bitmap.toPebbleBitmap); app-side call sites convert at the point of rendering. Drop the @stable Compose annotations from the interfaces. - Extract the Contacts interface out of LibPebble.kt into its own contacts/Contacts.kt. - Move FakeLibPebble from connection/ to a dedicated fake/ package and split the fake ConnectedPebbleDevice out into connection/FakeConnectedDevice.kt. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Entire-Checkpoint: 7694c2603501
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Decouple the published API surface from Compose so external consumers don't need AndroidX/Compose, and tidy the surface for standalone consumption: