libpebble3: make internal implementation classes internal#233
Open
SalvatoreT wants to merge 1 commit into
Open
libpebble3: make internal implementation classes internal#233SalvatoreT wants to merge 1 commit into
internal#233SalvatoreT wants to merge 1 commit into
Conversation
Tighten the published ABI of the connection package by marking implementation-only classes `internal`, so they (and the kable Peripheral type they carry) don't appear in the public API of the standalone artifact: - BlePlatformIdentifier: `internal` ctor + `internal val peripheral` (hides the com.juul.kable.Peripheral type). - WatchManager: `internal` ctor. - LegacyBtClassicMigrator: `internal` class. All three are only constructed within libpebble3 (via DI), so this is ABI-only. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Entire-Checkpoint: 17b4842c3fd0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tighten the published ABI of the connection package by marking implementation-only classes
internal, so they (and the kable Peripheral type they carry) don't appear in the public API of the standalone artifact:internalctor +internal val peripheral(hides the com.juul.kable.Peripheral type).internalctor.internalclass.All three are only constructed within libpebble3 (via DI), so this is ABI-only.