fix: expression table-alias quoting, zero lint issues (#21)#22
Merged
Conversation
CompareExp, InExp, LikeExp, BetweenExp, and HashExp all called dialect.QuoteIdentifier() directly, wrapping "table.column" as a single identifier instead of splitting into "table"."column". Extract shared quoteColumn() helper and apply it to all expression types. SelectQuery.quoteColumnName() now delegates to the same helper. 36 new test cases covering all expression types with table aliases across PostgreSQL, MySQL, and SQLite dialects.
Extract repeated string literals into package-level constants (28 goconst). Replace deprecated reflect.Ptr with reflect.Pointer (21 govet). golangci-lint now reports 0 issues across the entire codebase.
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CompareExp.Build()and all other expression types now correctly split table-aliased column names ("table"."column"instead of"table.column")reflect.Ptrwithreflect.Pointer(21 govet)Affected expressions
All expression types that quote column names:
Eq,NotEq,GreaterThan,LessThan,GreaterOrEqual,LessOrEqual,In,NotIn,Between,NotBetween,Like,NotLike,HashExp.Test plan
golangci-lint run ./...= 0 issuesgofmt -l .= clean