fix: replace all public API panics with stored errors, register pgx#24
Merged
Conversation
…ialect 17 panic paths converted to stored buildErr pattern across SelectQuery, UpdateQuery, DeleteQuery, BatchInsertQuery, BatchUpdateQuery, and LikeExp. Errors propagate through Build()/Execute()/All()/One() via Query.prepErr. - SelectQuery: Where/OrWhere/Having wrong type, FromSelect empty alias, With/WithRecursive invalid args, JOIN invalid ON type - UpdateQuery/DeleteQuery: Where/OrWhere wrong type - BatchInsertQuery: Values() count mismatch, Build() no rows - BatchUpdateQuery: Build() no updates - LikeExp: EscapeChars() odd argument count - Model(nil): nil guard in inferTableName - WrapDB(nil): clear panic message at construction - GetDialect: actionable error listing supported dialects - RegisterDialect pgx as PostgresDialect 19 new test functions (309 lines) in builder_error_test.go.
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
buildErrerrors that propagate through Build()/Execute()/All()/One()Open("pgx", dsn)now works as PostgreSQLAffected methods
SelectQuery:
Where(),OrWhere(),Having(),FromSelect(),With(),WithRecursive(), JOIN ONUpdateQuery/DeleteQuery:
Where(),OrWhere()BatchInsertQuery:
Values(),Build()BatchUpdateQuery:
Build()LikeExp:
EscapeChars()Test plan
builder_error_test.gogolangci-lint run ./...= 0 issuesWrapDB(nil)(constructor) andGetDialect(unknown)(actionable message)