style: SQL operator spacing, package godoc, deprecation markers, safety docs#27
Merged
Conversation
…n markers, safety docs
Quality polish (P4):
- CompareExp/HashExp/InExp: add spaces around operators for readable SQL
output ("col" = ? instead of "col"=?)
- Package godoc: updated to recommended API (db.Select, relica.Eq,
db.Model) instead of deprecated db.Builder().Select("*")
- NewDB: deprecated marker in standard gopls format
- CaseWhen: WARNING in godoc about raw SQL condition strings
- scanner: explicit nil pointer check with clear error message
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
P4 quality polish — 5 items from enterprise audit.
Changes
"col"=?→"col" = ?across CompareExp, HashExp, InExp for readable SQL outputdb.Select(),relica.Eq(),db.Model()) instead of deprecateddb.Builder().Select("*")// Deprecated: Use Open instead.format (picked up by gopls)One(&nilPtr)now returns"dest is a nil pointer, pass a non-nil *User"instead of"got pointer to invalid"Test plan
golangci-lint run ./...= 0 issues