Open
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request, generated by a workflow, syncs repository templates. The change in .copr/Makefile incorrectly removes a command to download a source file required for the COPR build. This will cause the build to fail. I have left a comment on the removed line explaining why it should be restored.
| # similar to https://github.com/actions/checkout/issues/760, but for COPR | ||
| git config --global --add safe.directory '*' | ||
| curl -LOf https://src.fedoraproject.org/rpms/rust-afterburn/raw/rawhide/f/rust-afterburn.spec | ||
| curl -LOf https://src.fedoraproject.org/rpms/rust-afterburn/raw/rawhide/f/90-afterburn-authorized-keys-file.conf |
There was a problem hiding this comment.
This line should not have been removed. It downloads 90-afterburn-authorized-keys-file.conf, which is a source file required by rust-afterburn.spec. The spec file is downloaded from Fedora Rawhide in the preceding line and lists this file as Source1. Removing this curl command will cause the rpmbuild step to fail because the source file will be missing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created by GitHub workflow (source).
Sync with coreos/repo-templates@31f11ac.