Skip to content

tests: add kdump over NFS #3922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 17, 2025
Merged

Conversation

jbtrystram
Copy link
Contributor

This was previously merged in [1] then reverted in [2] because the nfs
server container was not multi-arch, causing the pipeline to trip on it.

It's also not functionning on systemd256 (so anything f41 and above),
see [3]

This requires #3917 for
the multi-arch container, and
#3921

[1] b10d8dc
[2] af1468c
[3] rhkdump/kdump-utils#52

@jbtrystram jbtrystram added the hold-for-external Needs an external dependency to change label Nov 3, 2024
@jbtrystram
Copy link
Contributor Author

/hold
Let's wait for rhkdump/kdump-utils#52 or denylist on f41 and above
Also the quay.io/coreos-asembler/nfs does not exist now, i am hitting coreos/fedora-coreos-pipeline#1053

@jbtrystram jbtrystram changed the title tests/containers: add a NFS server containers tests: add kdump over NFS Nov 3, 2024
@HuijingHei
Copy link
Member

/retest

@jbtrystram
Copy link
Contributor Author

ah, I got excited because I saw dracut 105 got in stable but I forgot we pinned the previous version because it broke multipath tests... still waiting I guess

@jbtrystram jbtrystram added the hold-for-external Needs an external dependency to change label Apr 2, 2025
@jbtrystram
Copy link
Contributor Author

/retest

This way we have good coverage of most-used kdump features.
Some context on the NFS kdump configuration:
coreos/fedora-coreos-tracker#1729

This was previously merged in [1] then reverted in [2] because the nfs
server container was not multi-arch, causing the pipeline to trip on it.

It's also not functionning on systemd256 (so anything f41 and above),
see [3]

This requires coreos#3917 for
the multi-arch container, and
coreos#3921

[1] coreos@b10d8dc
[2] coreos@af1468c
[3] rhkdump/kdump-utils#52
@jbtrystram
Copy link
Contributor Author

rebased. The test pass on a rawhide build which have dracut 105, so we just need to wait for testing-devel to rebase to F42 content.

@dustymabe
Copy link
Member

rebased. The test pass on a rawhide build which have dracut 105, so we just need to wait for testing-devel to rebase to F42 content.

This should happen next week so we won't have to wait long.

@jbtrystram
Copy link
Contributor Author

[2025-04-17T07:43:54.376Z] --- PASS: kdump.crash.nfs (140.24s)

🎉

@jbtrystram jbtrystram removed the hold-for-external Needs an external dependency to change label Apr 17, 2025
@jbtrystram jbtrystram enabled auto-merge (rebase) April 17, 2025 11:40
@dustymabe
Copy link
Member

Can we get the commit message updated to be more accurate now? i.e. it states that it doesn't work on anything f41 and above, which clearly isn't accurate now because we are on f42 and it passes.

Copy link
Member

@dustymabe dustymabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small typos - optional fix - LGTM

})
}

// This function test the remote kdump feature by:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// This function test the remote kdump feature by:
// This function tests the remote kdump feature by:

}

// crash the kernel
// use systemd-run because direclty calling `echo c > ...` will always
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// use systemd-run because direclty calling `echo c > ...` will always
// use systemd-run because directly calling `echo c > ...` will always

@jbtrystram jbtrystram merged commit 33ad2bd into coreos:main Apr 17, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants