cmd-remote-build-container: add --write-digest-to-file#4048
cmd-remote-build-container: add --write-digest-to-file#4048jlebon merged 1 commit intocoreos:mainfrom
Conversation
This basically maps to podman's `--digestfile` option. This is useful as a way to reference the pushed image by digest instead of by tag.
| if os.environ.get('CONTAINER_HOST') is None or os.environ.get('CONTAINER_SSHKEY') is None: | ||
| sys.exit('You must have CONTAINER_HOST and CONTAINER_SSHKEY environment variables setup') | ||
| if args.write_digest_to_file is not None and not args.push_to_registry: | ||
| sys.exit('argument --write-digest-to-file can only be used with --push-to-registry') |
There was a problem hiding this comment.
I couldn't find an easy way to express this using more argparse-native APIs instead.
There was a problem hiding this comment.
There this file will be? in the remote or in the host? Don't we need something like the pull_oci_archive_from_remote ?
There was a problem hiding this comment.
It will be on the host. It seems like podman is smart enough in this case to do the pushing on the remote, but the writing of this file on the host.
|
/override ci/prow/rhcos |
|
@jlebon: Overrode contexts on behalf of jlebon: ci/prow/rhcos DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
3 participants
This basically maps to podman's
--digestfileoption. This is useful as a way to reference the pushed image by digest instead of by tag.