Add CentOS Stream keys, add cosa podman-build#4054
Merged
jlebon merged 2 commits intocoreos:mainfrom Apr 1, 2025
Merged
Conversation
This goes together with a related patch in openshift/os. Copying the
same context from that one:
A long-standing issue that rears its head in various places in our
code is the fact that the repo files for CentOS Stream reference a
`gpgkey` path that is valid only for cosa but not within a CentOS Stream
environment. See e.g. 0a7ad3b ("extensions: Workaround for CentOS GPG
key paths") in the openshift/os repo for an example issue.
We don't have this problem with RHEL because cosa, being Fedora-based,
ships the Red Hat key in its `/etc/pki/rpm-gpg`. I want to address this
for CentOS Stream the same way, i.e. by adding the CentOS Stream keys to
`/etc/pki/rpm-gpg` in cosa. This should allow us to simplify code there.
This is basically a thin wrapper around `podman build` to make it easier to get the arguments right. The fanciest part really is the passing of the secret repos file into the build environment. Example usage: ``` cosa podman-build node cosa podman-build extensions ``` Additional arguments are passed through to `podman build`.
Member
Author
Sigh. Looks like our continuous repo was nuked again. |
Member
Author
|
/retest |
Member
|
Is this intended to be run inside the When I run it it gives me: |
Member
Author
Hmm.. yeah. This kinda was written for my workflow I guess :), which is that cosa is just in my pet container and I mean, we could also transparently do |
Member
Yeah this would be nice, but the problem there is the paths inside and outside of COSA are different so I don't think it would work. |
Member
Author
|
Yeah, I guess it'd need to be |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See individual commit messages. Goes together with openshift/os#1780.