cmd-podman-build: stop passing the git yum repos#4066
Merged
dustymabe merged 1 commit intocoreos:mainfrom Apr 5, 2025
Merged
Conversation
jlebon
force-pushed
the
pr/podman-build-repos
branch
2 times, most recently
from
afea00a to
2abc1cd
Compare
This goes together with Jonathan's commit in openshift/os#1498 titled "build-node-image.sh: include yum repos from git as part of build". There's no point in adding the repo files already in the git repo into the secret; the node and extension builds already have access to those. So we'd just be duplicating them. Another way to think of this is that the secret injection we do here should be considered equivalent to `get-ocp-repo.sh` in OpenShift CI in terms of what repos get injected.
jlebon
force-pushed
the
pr/podman-build-repos
branch
from
2abc1cd to
3dbdab4
Compare
dustymabe
approved these changes
Apr 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This goes together with Jonathan's commit in
openshift/os#1498 titled "build-node-image.sh: include yum repos from git as part of build".
There's no point in adding the repo files already in the git repo into the secret; the node and extension builds already have access to those. So we'd just be duplicating them.
Another way to think of this is that the secret injection we do here should be considered equivalent to
get-ocp-repo.shin OpenShift CI in terms of what repos get injected.