Limit smp to 255 for libguestfish#4495
Merged
dustymabe merged 1 commit intocoreos:mainfrom Mar 18, 2026
Merged
Conversation
angelcerveraroldan
force-pushed
the
smp-limit
branch
from
04b27ba to
70c9e9f
Compare
libguestfs will fail with `-set-smp v` for `v` greater than 255. This can be seen in their source code: https://github.com/libguestfs/libguestfs/blob/5011bea96da06878864149767650bcc41f425fb9/lib/handle.c#L916
angelcerveraroldan
force-pushed
the
smp-limit
branch
from
70c9e9f to
8de60f7
Compare
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
The pull request effectively addresses the libguestfs limitation of 255 vCPUs by introducing logic to cap the set-smp value. This is a good improvement to prevent potential failures when kola ncpu returns a higher value. However, there is a critical syntax error in the conditional statement that needs to be corrected for the limit to function as intended.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
libguestfs will fail with
-set-smp vforvgreater than 255. This can be seen in their source code:https://github.com/libguestfs/libguestfs/blob/5011bea96da06878864149767650bcc41f425fb9/lib/handle.c#L916