Skip to content

support cosa buildextend-nvidiabluefield; drop linters #4496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dustymabe merged 2 commits into from
Mar 18, 2026
+2 −38
Merged

support cosa buildextend-nvidiabluefield; drop linters #4496

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0f43867
support cosa buildextend-nvidiabluefield
dustymabe Mar 18, 2026
6d96e46
drop .github/workflows/lints.yml
dustymabe Mar 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 0 additions & 37 deletions .github/workflows/lints.yml
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion cmd/coreos-assembler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ import (
// commands we'd expect to use in the local dev path
var buildCommands = []string{"init", "fetch", "build", "osbuild", "run", "prune", "clean", "list"}
var advancedBuildCommands = []string{"import", "buildfetch", "buildupload", "oc-adm-release", "push-container"}
var buildextendCommands = []string{"aliyun", "applehv", "aws", "azure", "digitalocean", "exoscale", "gcp", "hyperv", "ibmcloud", "kubevirt", "live", "metal", "metal4k", "nutanix", "openstack", "oraclecloud", "qemu", "secex", "virtualbox", "vmware", "vultr"}
var buildextendCommands = []string{"aliyun", "applehv", "aws", "azure", "digitalocean", "exoscale", "gcp", "hyperv", "ibmcloud", "kubevirt", "live", "metal", "metal4k", "nutanix", "nvidiabluefield", "openstack", "oraclecloud", "qemu", "secex", "virtualbox", "vmware", "vultr"}
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Mar 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For better readability and easier maintenance, consider formatting this long slice with one element per line. This makes future changes easier to review in diffs and helps prevent merge conflicts.

var buildextendCommands = []string{
	"aliyun",
	"applehv",
	"aws",
	"azure",
	"digitalocean",
	"exoscale",
	"gcp",
	"hyperv",
	"ibmcloud",
	"kubevirt",
	"live",
	"metal",
	"metal4k",
	"nutanix",
	"nvidiabluefield",
	"openstack",
	"oraclecloud",
	"qemu",
	"secex",
	"virtualbox",
	"vmware",
	"vultr",
}


var utilityCommands = []string{"aws-replicate", "coreos-prune", "compress", "copy-container", "diff", "koji-upload", "kola", "push-container-manifest", "remote-build-container", "remote-session", "sign", "tag", "update-variant"}
var otherCommands = []string{"shell", "meta"}
Expand Down
1 change: 1 addition & 0 deletions src/cmd-buildextend-nvidiabluefield
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
./cmd-osbuild