WIP: Containerfile: move from build-chunked-oci to chunkah#3993
Draft
jlebon wants to merge 1 commit intocoreos:testing-develfrom
Draft
WIP: Containerfile: move from build-chunked-oci to chunkah#3993jlebon wants to merge 1 commit intocoreos:testing-develfrom
jlebon wants to merge 1 commit intocoreos:testing-develfrom
Conversation
There was a problem hiding this comment.
Code Review
This pull request replaces the usage of rpm-ostree experimental compose build-chunked-oci with a new tool, chunkah, for creating the OCI image. This is implemented via a new multi-stage build in the Containerfile. While the approach is sound, I've found a critical issue with incorrect paths in the new build stage that will likely cause the build to fail. My review includes a specific comment and a code suggestion to address this.
Member
|
Not sure I understand the CI failure here: |
Notably this implicitly moves FCOS from OSTree-based to "plain" OCI images.
Member
Author
|
This is now blocked on bootc-dev/bootc#1637. I will work on fixing that and then adding chunkah to the base fedora-bootc image before we circle back to turning it on in fedora-bootc and here. So, might take some time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notably this implicitly moves FCOS from OSTree-based to "plain" OCI
images.
Mostly for demonstration purposes at this point. :)