platforms/hetzner: Console configuration for aarch64 systems#4008
platforms/hetzner: Console configuration for aarch64 systems#4008Rolv-Apneseth wants to merge 1 commit intocoreos:testing-develfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds console configuration for Hetzner aarch64 systems. The change is straightforward and adds a new platform definition. I have one suggestion to improve consistency with the existing configurations in the file. Using console=tty0 instead of console=tty1 would align this new entry with all other platforms, improving maintainability unless tty1 is specifically required for Hetzner.
| - terminal_input serial console | ||
| - terminal_output serial console | ||
| kernel_arguments: | ||
| - console=tty1 |
There was a problem hiding this comment.
For consistency with other platform configurations in this file, please consider using console=tty0 instead of console=tty1. tty0 is used for the virtual console across all other platform definitions here. If tty1 is specifically required for Hetzner aarch64 systems, it would be helpful to add a comment explaining why.
- console=tty0There was a problem hiding this comment.
Not sure why - it's just what I saw all the other OSes using. I listed /proc/cmdline outputs in this comment
Add console configuration for Hetzner aarch64 systems in order to enable console output between the grub menu and login prompt. Related issue: coreos/fedora-coreos-tracker#1959
Rolv-Apneseth
force-pushed
the
hetzner-kargs
branch
from
c2501af to
10c3279
Compare
1 participant
Opening this PR to hopefully lead to further discussions on how to proceed with coreos/fedora-coreos-tracker#1959
As described there, it seems there is room to improve the solution, but I'm not sure how.