Tofu: Add x86_64 #1102
Open
Tofu: Add x86_64 #1102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onfig - Sync the x86_64 Butane config with the existing aarch64 configuration. - This change eliminates the need for a special tofu-related modification, as tofu already handles the merge automatically. Signed-off-by: Renata Ravanelli <[email protected]>
- Although duplicating code isn't ideal, tofu doesn't support managing resource
names and global variables values using variables as declaration very well.
For example:
We can not do:
variable "project" {
type = string
default = "coreos-${var.arch}-builder"
}
What creates limitation to merge aarch64 and x86_64.
- As a result, add x86_64 now
- The goal is to find an efficient way to merge both architectures in the
future, since it shares the same code.
Signed-off-by: Renata Ravanelli <[email protected]>
|
I'd really like to get a day or two to sit down and resolve this with #986 and test everything out again. One day! |
aaa I didn't see we had this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.