Open
Conversation
Collaborator
|
Hey @marcinwyszynski, happy holidays Would you mind taking a look at my comment: #406 (review) These errors happen before the token signature is validated (as a small optimization), so there's likely a lot of scenarios where the data return in the error isn't safe to use. In both cases, package users can do audience and issuer validation themselves using some of the Skip options in the Config: https://pkg.go.dev/github.com/coreos/go-oidc/v3/oidc#Config. Which should cover the cases where users want to programmatically do something based on what audience or issuer is returned. Am I missing any use case here? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull Request adds error types to some of the errors returned but the
IDTokenVerifier.Verifymethod.The reasoning here is that in some cases these errors can return more information than you'd like to present to the caller. If you need to perform some filtering on your end (eg. disclose the presented but not the expected audience), it would be more convenient to do it based on well-defined types.
I added tests to ensure that the presented error messages are backwards compatible, and that returned errors are of the correct type. For that I extended the existing testing framework to allow more introspection on returned errors.
I hope it's OK that I used generics here. Looking at the
go.modfile it should be supported out of the box but if you prefer me to rewrite it without generics, that's not a biggie either.Thanks!