Open
Conversation
Author
|
@ericchiang Hi! could you check this PR please? |
Collaborator
|
Hey! Sorry, but seems like the correct ordering. If the URL you provide to this library is http://localhost:4444, and the server returns something different, then the library expects localhost but got a different value. Maybe "configured to expect localhost, but server returned 127.0.0.1" would be clearer? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I try to connect to Oauth provider with wrong url I got wrong error message. In example I use localhost:4444 instead of 127.0.0.1.
Error message:
error="failed to create OAuth service: failed to create OIDC provider: oidc: issuer did not match the issuer returned by provider, expected \"http://localhost:4444\" got \"http://127.0.0.1:4444\""But should be:
error="failed to create OAuth service: failed to create OIDC provider: oidc: issuer did not match the issuer returned by provider, expected \"http://127.0.0.1:4444\" got \"http://localhost:4444\""When i change host to http://127.0.0.1:4444, everything works correctly and got no errors