fix: Key refresh should set no-cache to get most up to date keys#485
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the HTTP client fetches the keys without a
Cache-Controlheader. This can lead to potential issues because, with the current logic, we always attempt to revalidate when we encounter an unknownkid. Therefore, we want to ensure that we retrieve the most up-to-date keys from the OIDC server.For this reason, we should include a
Cache-Control: no-cacheheader in the request to ensure that the keys are revalidated and that we do not receive a stale key set from an intermediary proxy.Fixes #484