Skip to content

update golangci-lint to v2.10.1#513

Closed
Luap99 wants to merge 1 commit intocoreos:mainfrom
Luap99:bump-golangci-lint
Closed

update golangci-lint to v2.10.1#513
Luap99 wants to merge 1 commit intocoreos:mainfrom
Luap99:bump-golangci-lint

Conversation

@Luap99
Copy link
Collaborator

@Luap99 Luap99 commented Mar 6, 2026

The older version does not support go 1.26 but the workflow installs go 1.26 as it ask for the stable go version. Therefore CI fails currently. Fix this by updating golangci-lint to the latest version which does support go 1.26.

The older version does not support go 1.26 but the workflow installs go
1.26 as it ask for the stable go version. Therefore CI fails currently.
Fix this by updating golangci-lint to the latest version which does
support go 1.26.

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
@Luap99 Luap99 requested a review from kolyshkin March 6, 2026 12:40
@Luap99
Copy link
Collaborator Author

Luap99 commented Mar 6, 2026

Looks like we have a nasty flake, took 5 tries to get the one job passing

https://github.com/coreos/go-systemd/actions/runs/22762902976/attempts/4?pr=513

+ docker exec --privileged 403f10766dcc2c0fc1f2b48e3195e0c3adc18801299d617aa93cd88894b992fa /bin/bash -e -c 'cd /src; ./scripts/ci-runner.sh build_tests'
Building tests...
  - activation
internal/byteorder: open /tmp/go-build3549252721/b014/_pkg_.a: no such file or directory
# internal/abi
asm: open $WORK/b006/symabis: no such file or directory
# internal/godebugs
compile: -importcfg: open $WORK/b016/importcfg: no such file or directory
# runtime/internal/math
/usr/local/go/src/runtime/internal/math/math.go:7:8: could not import internal/goarch (open $WORK/b007/_pkg_.a: no such file or directory)
# runtime/internal/sys
/usr/local/go/src/runtime/internal/sys/consts.go:8:2: could not import internal/goarch (open $WORK/b007/_pkg_.a: no such file or directory)
# internal/cpu
can't create $WORK/b012/_pkg_.a: open $WORK/b012/_pkg_.a: no such file or directory
internal/goarch: open /tmp/go-build3549252721/b007/vet.cfg: no such file or directory
internal/coverage/rtcov: open /tmp/go-build3549252721/b015/vet.cfg: no such file or directory
internal/unsafeheader: open /tmp/go-build3549252721/b009/vet.cfg: no such file or directory

Seems to be a race condition when compiling go programs?!

@Luap99
Copy link
Collaborator Author

Luap99 commented Mar 13, 2026

replaced by #515

@kolyshkin
Copy link
Collaborator

Looks like we have a nasty flake, took 5 tries to get the one job passing

https://github.com/coreos/go-systemd/actions/runs/22762902976/attempts/4?pr=513

+ docker exec --privileged 403f10766dcc2c0fc1f2b48e3195e0c3adc18801299d617aa93cd88894b992fa /bin/bash -e -c 'cd /src; ./scripts/ci-runner.sh build_tests'
Building tests...
  - activation
internal/byteorder: open /tmp/go-build3549252721/b014/_pkg_.a: no such file or directory
# internal/abi
asm: open $WORK/b006/symabis: no such file or directory
# internal/godebugs
compile: -importcfg: open $WORK/b016/importcfg: no such file or directory
# runtime/internal/math
/usr/local/go/src/runtime/internal/math/math.go:7:8: could not import internal/goarch (open $WORK/b007/_pkg_.a: no such file or directory)
# runtime/internal/sys
/usr/local/go/src/runtime/internal/sys/consts.go:8:2: could not import internal/goarch (open $WORK/b007/_pkg_.a: no such file or directory)
# internal/cpu
can't create $WORK/b012/_pkg_.a: open $WORK/b012/_pkg_.a: no such file or directory
internal/goarch: open /tmp/go-build3549252721/b007/vet.cfg: no such file or directory
internal/coverage/rtcov: open /tmp/go-build3549252721/b015/vet.cfg: no such file or directory
internal/unsafeheader: open /tmp/go-build3549252721/b009/vet.cfg: no such file or directory

Seems to be a race condition when compiling go programs?!

Seeing a similar failure when building Go tests:

+ docker exec --privileged 3af3363f4fe6554efe0758e8a841d6f8186d726850468922bd6b1c470c970014 /bin/bash -e -c 'cd /src; ./scripts/ci-runner.sh build_tests'
Building tests...
  - activation
github.com/coreos/go-systemd/v22/activation.test: open /tmp/go-build4063755751/b001/importcfg: no such file or directory

It looks like someone removes /tmp while go compiles code. My guess it's systemd.

I think that sleep 10s (initially added as sleep 30s in commit 07d38cb) in ci-runner.sh was previously helping with that. As much as I hate such kludges, maybe we need to move it to before building tests.

Opened #516 to fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants