Conversation
Most users of this library are going to be using e.g. serde to parse the individual config files into a final merged state. This API is similar to e.g. https://doc.rust-lang.org/std/iter/trait.Iterator.html#method.reduce As the API comment says - right now this is not more efficient, but it could be if we unified things internally because we could avoid allocating a `BTreeMap` of all the filenames.
|
IDGI. How do you expect to be able to get rid of the map? The list of files to visit is only known after you visit everything. |
We'd likely need to invoke Honestly I don't think the performance matters too much; the set of files is pretty small in most cases. The case where it may matter a bit more is when one is using a basedir of e.g. This PR isn't super important to me, I just decided to try it; it worked out OK, but I wouldn't say it's super compelling. It may be more bang-for-the-buck to just have example code that uses serde that people can copy-and paste for now. |
2 participants
Most users of this library are going to be using e.g. serde to parse the individual config files into a final merged state.
This API is similar to e.g.
https://doc.rust-lang.org/std/iter/trait.Iterator.html#method.reduce
As the API comment says - right now this is not more efficient, but it could be if we unified things internally because we could avoid allocating a
BTreeMapof all the filenames.