-
Notifications
You must be signed in to change notification settings - Fork 24
NO-JIRA: Bump fedora-coreos-config #165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@coreosbot-releng: This pull request explicitly references no jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the fedora-coreos-config submodule to a newer commit. This is an automated change that brings in a series of refactorings and enhancements from the submodule, as detailed in the commit messages. Since the only change is the submodule pointer, there are no direct code modifications to review in this pull request. The update appears to be a standard dependency bump and looks correct.
Dusty Mabe (9):
build-rootfs: lower more code into build_rootfs() function
build-rootfs: collapse vars into a dictionary
build-rootfs: add `make-rootfs` top level command
build-rootfs: rename arg for get_treefile
build-rootfs: parameterize srcdir
build-rootfs: add `build-rootfs parse-treefile` sub command
build-rootfs: rename id var to osid
build-rootfs: add error checking for input env vars
versionary: handle corner case with SCOS versioning
Joel Capitao (1):
.tekton: update konflux references to latest
b3363fc to
ca2a385
Compare
|
/lgtm See #163 - we're trying to fix the rt test |
|
@dustymabe: Overrode contexts on behalf of dustymabe: ci/prow/scos-10-build-test-qemu DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: coreosbot-releng, dustymabe The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
/override ci/prow/scos-10-build-test-qemu |
|
@dustymabe: Overrode contexts on behalf of dustymabe: ci/prow/scos-10-build-test-qemu DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Created by GitHub workflow (source).