Skip to content

Conversation

@coreosbot-releng
Copy link

@coreosbot-releng coreosbot-releng commented Jan 29, 2026

Created by GitHub workflow (source).

Dusty Mabe (9):
      build-rootfs: lower more code into build_rootfs() function
      build-rootfs: collapse vars into a dictionary
      build-rootfs: add `make-rootfs` top level command
      build-rootfs: rename arg for get_treefile
      build-rootfs: parameterize srcdir
      build-rootfs: add `build-rootfs parse-treefile` sub command
      build-rootfs: rename id var to osid
      build-rootfs: add error checking for input env vars
      versionary: handle corner case with SCOS versioning

Joel Capitao (1):
      .tekton: update konflux references to latest

@openshift-ci-robot
Copy link

@coreosbot-releng: This pull request explicitly references no jira issue.

Details

In response to this:

Created by GitHub workflow (source).

Dusty Mabe (8):
     build-rootfs: lower more code into build_rootfs() function
     build-rootfs: collapse vars into a dictionary
     build-rootfs: add `make-rootfs` top level command
     build-rootfs: rename arg for get_treefile
     build-rootfs: parameterize srcdir
     build-rootfs: add `build-rootfs parse-treefile` sub command
     build-rootfs: rename id var to osid
     build-rootfs: add error checking for input env vars

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the fedora-coreos-config submodule to a newer commit. This is an automated change that brings in a series of refactorings and enhancements from the submodule, as detailed in the commit messages. Since the only change is the submodule pointer, there are no direct code modifications to review in this pull request. The update appears to be a standard dependency bump and looks correct.

Dusty Mabe (9):
      build-rootfs: lower more code into build_rootfs() function
      build-rootfs: collapse vars into a dictionary
      build-rootfs: add `make-rootfs` top level command
      build-rootfs: rename arg for get_treefile
      build-rootfs: parameterize srcdir
      build-rootfs: add `build-rootfs parse-treefile` sub command
      build-rootfs: rename id var to osid
      build-rootfs: add error checking for input env vars
      versionary: handle corner case with SCOS versioning

Joel Capitao (1):
      .tekton: update konflux references to latest
@dustymabe
Copy link
Member

/lgtm
/override ci/prow/scos-10-build-test-qemu

See #163 - we're trying to fix the rt test

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 29, 2026

@dustymabe: Overrode contexts on behalf of dustymabe: ci/prow/scos-10-build-test-qemu

Details

In response to this:

/lgtm
/override ci/prow/scos-10-build-test-qemu

See #163 - we're trying to fix the rt test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 29, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: coreosbot-releng, dustymabe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dustymabe
Copy link
Member

/retest

@dustymabe
Copy link
Member

/override ci/prow/scos-10-build-test-qemu

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 29, 2026

@dustymabe: Overrode contexts on behalf of dustymabe: ci/prow/scos-10-build-test-qemu

Details

In response to this:

/override ci/prow/scos-10-build-test-qemu

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit ffd11b2 into coreos:main Jan 29, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants