tests: add new test to verify RHCOS system detection on s390x#175
tests: add new test to verify RHCOS system detection on s390x#175nikita-dubrovskii wants to merge 1 commit intocoreos:mainfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: nikita-dubrovskii The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new test to verify the RHCOS system level identification on s390x architectures. The test logic itself appears sound and correctly checks for the RHCOS identifier based on the linked s390-tools fix. However, there is a critical issue in how a shared utility script, commonlib.sh, is included. It's currently added as a text file containing a path instead of a symbolic link, which will cause the test script to fail at runtime. I've also pointed out a minor typo in a code comment.
nikita-dubrovskii
force-pushed
the
cpilevel_test
branch
from
ccbe72d to
8229e34
Compare
|
Until we get new RPMs, this shouldn't be merged |
nikita-dubrovskii
force-pushed
the
cpilevel_test
branch
from
8229e34 to
3995d24
Compare
RHCOS was incorrectly showing in HMC as RHEL because `system_level` value was wrong. This test verifies the fix introduced in s390-tools PR ibm-s390-linux/s390-tools#199, ensuring that `/sys/firmware/cpi/system_level` correctly identifies the OS as RHCOS.
nikita-dubrovskii
force-pushed
the
cpilevel_test
branch
from
3995d24 to
a8e0a18
Compare
1 participant
RHCOS was incorrectly showing in HMC as RHEL because
system_levelvalue was wrong. This test verifies the fix introduced in s390-tools PR ibm-s390-linux/s390-tools#199, ensuring that/sys/firmware/cpi/system_levelcorrectly identifies the OS as RHCOS.