Add new zincati-update-now command#1259
Conversation
This addresses the gap identified in coreos#498 in a blunt way by setting some runtime config knobs so Zincati in effect immediately downloads, deploys, and reboots the system. The motivation to at least have this for now is coreos#1241, which will purposely break `rpm-ostree upgrade --bypass-driver`. But clearly the approach here is applicable regardless of whether the node has switched to OCI. In the future, this may either get replaced by a proper `zincatictl` entrypoint, or by better integration into the system's update tooling (e.g. bootc), so that `bootc upgrade` does the right thing.
prestist
left a comment
prestist
left a comment
There was a problem hiding this comment.
From a code perspective LGTM!
| echo "WARN: This command is experimental and subject to change." >&2 | ||
|
|
||
| # this should exist already, but in case | ||
| mkdir -p /run/zincati/config.d |
There was a problem hiding this comment.
So I am very much out of my depth here but I have to ask in what circumstance would this not exist but the services exist?
would that be an indication of other issues that might want to halt the update attempt ?
There was a problem hiding this comment.
doubt it, I think this only means that somehow the tmpfiles.d fragment didn't run
and I'm guessing we didn't name this |
I didn't think of it that way quite exactly, but yes I did intend to very clearly emphasize the stopgap nature of this. |
|
Tested this out and it seemed to work well! |
4 participants
This addresses the gap identified in
#498 in a blunt way by setting some runtime config knobs so Zincati in effect immediately downloads, deploys, and reboots the system.
The motivation to at least have this for now is
#1241, which will purposely break
rpm-ostree upgrade --bypass-driver. But clearly the approach here is applicable regardless of whether the node has switched to OCI.In the future, this may either get replaced by a proper
zincatictlentrypoint, or by better integration into the system's update tooling (e.g. bootc), so thatbootc upgradedoes the right thing.