Skip to content

tests/kola/experimental: fix LastRefreshTime method name#1260

Closed
jlebon wants to merge 1 commit intocoreos:mainfrom
jlebon:pr/last-refresh-time
Closed

tests/kola/experimental: fix LastRefreshTime method name#1260
jlebon wants to merge 1 commit intocoreos:mainfrom
jlebon:pr/last-refresh-time

Conversation

@jlebon
Copy link
Member

@jlebon jlebon commented Feb 27, 2025

We were using the wrong method name here.

Likely fixes #1176.

(E.g. maybe what happened there is that previously zbus would return "Access denied" for unauthorized users even for non-existent methods and maybe the logic changed so the existence check was done first.)

We were using the wrong method name here.

Likely fixes coreos#1176.

(E.g. maybe what happened there is that previously zbus would return
"Access denied" for unauthorized users even for non-existent methods and
maybe the logic changed so the existence check was done first.)
@HuijingHei
Copy link
Member

I tried manually with the build and failed, it is wired that busctl list does not even include org.coreos.zincati

# busctl call org.coreos.zincati /org/coreos/zincati org.coreos.zincati.Experimental LastRefreshTime
Call failed: The name is not activatable

@jlebon
Copy link
Member Author

jlebon commented Feb 27, 2025

I tried manually with the build and failed, it is wired that busctl list does not even include org.coreos.zincati

# busctl call org.coreos.zincati /org/coreos/zincati org.coreos.zincati.Experimental LastRefreshTime
Call failed: The name is not activatable

Hmm, I couldn't reproduce it locally.

Oh! I bet the test is racing with Zincati actually setting up D-Bus. Can you try adding a e.g. a loop that waits until zincati.service is active before we do the busctl calls?

@jbtrystram
Copy link
Member

I tried manually with the build and failed, it is wired that busctl list does not even include org.coreos.zincati

# busctl call org.coreos.zincati /org/coreos/zincati org.coreos.zincati.Experimental LastRefreshTime
Call failed: The name is not activatable

Hmm, I couldn't reproduce it locally.

Oh! I bet the test is racing with Zincati actually setting up D-Bus. Can you try adding a e.g. a loop that waits until zincati.service is active before we do the busctl calls?

I am able to reproduce this issue, even with this fix. Did you update zbus ?

@jlebon
Copy link
Member Author

jlebon commented Feb 27, 2025

OK yes, I can reproduce it now. But actually, Zincati isn't exposing a D-Bus service at all (which explains the error message), so there's something more fundamental going wrong here. I think possibly related to the way we use zbus+actix.

@HuijingHei
Copy link
Member

OK yes, I can reproduce it now. But actually, Zincati isn't exposing a D-Bus service at all (which explains the error message), so there's something more fundamental going wrong here. I think possibly related to the way we use zbus+actix.

Thanks! It is out of my knowledge now.

@dustymabe
Copy link
Member

I added the commit from this PR into #1309

@dustymabe dustymabe closed this Jul 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

zbus bump 3.6.1 to newer version makes busctl failed with Call failed: The name is not activatable

4 participants