feat: add support for 3rd party themes #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for classic 3rd party themes.
I know the idea of adding support for 3rd party plugins has been thrown around, but as others have mentioned that can result in the number of rule exclusions blowing up. All of the requests sent by themes are actually pretty similar, so this should be relatively low effort for a pretty high return, most WordPress users use 3rd party themes because the stock themes are limiting. Some themes add additional functionality via plugins, those won't be supported.
I've tested against the following themes:
Astra
Blocksy
Generate Press
Twenty Twelve
Ocean WP
Zakra