Skip to content

studio: declare host-provided libs as peerDependencies#3055

Merged
dpfaffenbauer merged 1 commit into
coreshop:5.1from
dpfaffenbauer:fix/5.1-peer-dependencies
May 27, 2026
Merged

studio: declare host-provided libs as peerDependencies#3055
dpfaffenbauer merged 1 commit into
coreshop:5.1from
dpfaffenbauer:fix/5.1-peer-dependencies

Conversation

@dpfaffenbauer

Copy link
Copy Markdown
Member

Summary

  • Move react, react-dom, antd, immer, @reduxjs/toolkit, react-redux and @pimcore/studio-ui-bundle from dependencies to peerDependencies in all 23 studio bundle package.jsons.
  • These libs are shared by the Pimcore Studio host via Module Federation, so the bundles should declare them as peers rather than direct deps.
  • Side effect: Dependabot stops proposing major bumps (e.g. react 19, antd 6, immer 11) that pimcore studio-ui-bundle doesn't support.
  • Replace 2 trivial isNil usages from lodash with value == null so lodash doesn't need to be declared as a dep/peer.

Test plan

  • npm install clean
  • npm run check-types --workspaces --if-present
  • npm run build
  • Studio UI loads (order state cell + relation field still render correctly)

@sonarqubecloud

Copy link
Copy Markdown

@dpfaffenbauer dpfaffenbauer merged commit bf3e4bf into coreshop:5.1 May 27, 2026
128 checks passed
@dpfaffenbauer dpfaffenbauer deleted the fix/5.1-peer-dependencies branch May 27, 2026 08:03
@github-actions github-actions Bot locked and limited conversation to collaborators May 27, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant