Enhance NVM_PATH input handling in install.cmd#1319
Open
manavortex wants to merge 1 commit intocoreybutler:masterfrom
Open
Enhance NVM_PATH input handling in install.cmd#1319manavortex wants to merge 1 commit intocoreybutler:masterfrom
manavortex wants to merge 1 commit intocoreybutler:masterfrom
Conversation
Add check for NVM_HOME variable and prompt for input if empty
On extracting portable file, nvm install version fails if NVM_HOME variable is unset ("\settings.txt can't be opened")
|
This PR is stale because it has been open 45 days with no activity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add check for NVM_HOME variable and prompt for input if empty
On extracting portable file, nvm install version fails if NVM_HOME variable is unset ("\settings.txt can't be opened"). Depending on whether or not the
install.cmdis even called, this might not fix the problem (I wasn't able to verify that).Anyhow, I figured making the check conditional is probably good practice?