Avoid diffs due to order of elements returned by the controller - #11
Open
bltavares wants to merge 1 commit into
Open
Avoid diffs due to order of elements returned by the controller #11bltavares wants to merge 1 commit into
bltavares wants to merge 1 commit into
Conversation
bltavares
force-pushed
the
reduce-diffs-due-to-ordering
branch
from
March 17, 2019 18:03
a086b8e to
519fff0
Compare
The network and member resource use a couple of settings which could be defined multiple times. For example: the assigned ips on a member could change the order, while the semantic means the same. The provider was using a `schema.ListType`, which according to the documentation is an *ordered* list of elements, where the order matter. On those resource seetings, the order is not relevant, as they are sematically equivalent. There is a `schema.SetType` which provides an *unordered* collection of settings, and grants the same order given the same settings. This commit changes the schema of those resources to use `schema.SetType` instead of `schema.ListType` to avoid diff loops depending on the sorting of the response from the API.
bltavares
force-pushed
the
reduce-diffs-due-to-ordering
branch
from
March 20, 2019 16:25
519fff0 to
1108256
Compare
Open
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The network and member resource use a couple of settings which could be
defined multiple times.
For example: the assigned ips on a member could change the order, while
the semantic means the same.
The provider was using a
schema.ListType, which according to thedocumentation is an ordered list of elements, where the order
matter.
On those resource seetings, the order is not relevant, as they are
sematically equivalent. There is a
schema.SetTypewhich provides anunordered collection of settings, and grants the same order given the
same settings.
This commit changes the schema of those resources to use
schema.SetTypeinstead ofschema.ListTypeto avoid diff loopsdepending on the sorting of the response from the API.