Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
It is intended to allow for #7 url proposal.
This proposal modified the existing constructor to take in required, named arguments. If you don't use the default constructor, then you must specify the argument you are setting
Aliasor(alias_file=<file>)
. This changes the behavior of the existing file argument as you can no longer callAliasor(<file>)
.I added the ability to specify a url via
Aliasor(alias_url=<url>)
.The use of required, named arguments should be implemented if you want to add different input data such as
str
(which can then be implemented asAliasor(alias_string=<str>)
). This makes it very clear what the caller wants to do.Related issue(s)
Testing
I added a test which takes in the default url currently provided, and tested that compress and uncompress logic still works correctly. I also updated the file constructor test to use the new required, named argument implementation.